Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Ensure to report only unrecognized sources as unrecognized #9449

Merged
merged 1 commit into from May 10, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented May 10, 2021

Fixes invalid report, as showcased in #9442

In this scenario self reveals as unrecognized, as it targets property to be resolved with unrecognized source.

I've fixed the implementation to simply filter out all recognized sources from all reported unresolved sources (technically any source may resolve with variable that points unrecognized source, so be subject to this error)

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #9449 (e64c12e) into master (8d56d0e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head e64c12e differs from pull request most recent head e70891a. Consider uploading reports for the commit e70891a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9449      +/-   ##
==========================================
- Coverage   86.90%   86.89%   -0.02%     
==========================================
  Files         321      321              
  Lines       11976    11978       +2     
==========================================
  Hits        10408    10408              
- Misses       1568     1570       +2     
Impacted Files Coverage Δ
scripts/serverless.js 49.60% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d56d0e...e70891a. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik May 10, 2021 11:29
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 27e21e8 into master May 10, 2021
@medikoo medikoo deleted the 0510-fix-unrecognized-source-listing branch May 10, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants