Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLI): Correctly resolve version during local fallback #9463

Merged
merged 1 commit into from
May 11, 2021

Conversation

pgrzesik
Copy link
Contributor

Closes: #9462

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, good catch!

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #9463 (96d3149) into master (3c5d713) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9463   +/-   ##
=======================================
  Coverage   86.91%   86.92%           
=======================================
  Files         321      321           
  Lines       11987    11986    -1     
=======================================
  Hits        10419    10419           
+ Misses       1568     1567    -1     
Impacted Files Coverage Δ
lib/cli/render-version.js 66.66% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5d713...96d3149. Read the comment docs.

@pgrzesik pgrzesik merged commit bbfe742 into master May 11, 2021
@pgrzesik pgrzesik deleted the correctly-resolve-version-during-local-fallback branch May 11, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serverless 2.4.1 - "Could not resolve path to locally installed serverless."
2 participants