New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stack errors processing #9505
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9505 +/- ##
==========================================
- Coverage 86.79% 86.76% -0.04%
==========================================
Files 322 322
Lines 12064 12093 +29
==========================================
+ Hits 10471 10492 +21
- Misses 1593 1601 +8
Continue to review full report at Codecov.
|
ad14976
to
11969cb
Compare
0c8c506
to
bb9f30a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Noticed 30+ error reports in mixpanel, pointing fact it's possibe that
ResourceStatusReason
is not provided on event we mark as error event.This patch ensures we do not dirty crash in such case.
Additionally:
ServerlessError
's inscripts/serverless.js
YamlParser
dependency (it introduced alternative YAML parsing approach, which was used just inplugin install/uninstall
commandplugin install/uninstall
commands so they're safe in user used variables to defineplugins
(so far such configuration dirty crashed)YAMLParser
as user error. In new configuration read logic all YAML parse errors are already communicated withServerlessError
and same should be in all other cases