Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack errors processing #9505

Merged
merged 5 commits into from May 20, 2021
Merged

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented May 20, 2021

Noticed 30+ error reports in mixpanel, pointing fact it's possibe that ResourceStatusReason is not provided on event we mark as error event.

This patch ensures we do not dirty crash in such case.

Additionally:

  • Added missing error codes to ServerlessError's in scripts/serverless.js
  • Remove internal YamlParser dependency (it introduced alternative YAML parsing approach, which was used just in plugin install/uninstall command
  • Improve plugin install/uninstall commands so they're safe in user used variables to define plugins (so far such configuration dirty crashed)
  • Remove recognition of YAMLParser as user error. In new configuration read logic all YAML parse errors are already communicated with ServerlessError and same should be in all other cases

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #9505 (f8f0504) into master (8d0ff07) will decrease coverage by 0.03%.
The diff coverage is 80.95%.

❗ Current head f8f0504 differs from pull request most recent head bb9f30a. Consider uploading reports for the commit bb9f30a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9505      +/-   ##
==========================================
- Coverage   86.79%   86.76%   -0.04%     
==========================================
  Files         322      322              
  Lines       12064    12093      +29     
==========================================
+ Hits        10471    10492      +21     
- Misses       1593     1601       +8     
Impacted Files Coverage Δ
lib/plugins/aws/provider.js 93.75% <ø> (ø)
scripts/serverless.js 51.31% <ø> (ø)
lib/plugins/plugin/install.js 94.31% <76.47%> (-4.32%) ⬇️
lib/plugins/plugin/uninstall.js 94.28% <76.47%> (-5.72%) ⬇️
lib/cli/interactive-setup/service.js 100.00% <100.00%> (ø)
lib/plugins/aws/lib/monitorStack.js 98.66% <100.00%> (ø)
lib/utils/tokenize-exception.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0ff07...bb9f30a. Read the comment docs.

@medikoo medikoo force-pushed the 0520-fix-stack-errors-processing branch from ad14976 to 11969cb Compare May 20, 2021 10:05
@medikoo medikoo requested a review from pgrzesik May 20, 2021 11:25
@medikoo medikoo force-pushed the 0520-fix-stack-errors-processing branch from 0c8c506 to bb9f30a Compare May 20, 2021 11:27
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@medikoo medikoo merged commit db16df2 into master May 20, 2021
@medikoo medikoo deleted the 0520-fix-stack-errors-processing branch May 20, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants