Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local invocation: Fix invalid result handling #9507

Merged
merged 1 commit into from
May 21, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented May 21, 2021

Noticed some programmer errors reported here. Fixed our logic to show meaningful error message instead

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #9507 (53b8ab3) into master (06c28e2) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9507      +/-   ##
==========================================
- Coverage   86.76%   86.75%   -0.01%     
==========================================
  Files         322      322              
  Lines       12093    12096       +3     
==========================================
+ Hits        10492    10494       +2     
- Misses       1601     1602       +1     
Impacted Files Coverage Δ
lib/plugins/aws/invokeLocal/index.js 68.75% <75.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c28e2...53b8ab3. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik May 21, 2021 12:10
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@medikoo medikoo merged commit bbff029 into master May 21, 2021
@medikoo medikoo deleted the 0521-fix-local-invocation-result-handling branch May 21, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants