Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper resolution in case of errors for AWS-related variables #9518

Merged
merged 1 commit into from
May 25, 2021

Conversation

pgrzesik
Copy link
Contributor

Fixes a regression introduced with more granular error codes from AWS calls

Closes: #9516

@pgrzesik pgrzesik changed the title Ensure proper resolution in case of errors Ensure proper resolution in case of errors for AWS-related variables May 25, 2021
@pgrzesik pgrzesik self-assigned this May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #9518 (3310249) into master (2984adb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9518   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files         322      322           
  Lines       12103    12103           
=======================================
  Hits        10500    10500           
  Misses       1603     1603           
Impacted Files Coverage Δ
...ion/variables/sources/instance-dependent/get-cf.js 95.65% <100.00%> (ø)
...ion/variables/sources/instance-dependent/get-s3.js 100.00% <100.00%> (ø)
...on/variables/sources/instance-dependent/get-ssm.js 93.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2984adb...3310249. Read the comment docs.

@pgrzesik pgrzesik merged commit ee66585 into master May 25, 2021
@pgrzesik pgrzesik deleted the fix-ensure-proper-resolution-in-case-of-errors branch May 25, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not using default value for SSM on 2.43.0
1 participant