Fix handling of numeric error codes coming from AWS SDK requests #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9538 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 321 321
Lines 12072 12075 +3
=======================================
+ Hits 10467 10470 +3
Misses 1605 1605
Continue to review full report at Codecov.
|
pgrzesik
previously approved these changes
Jun 1, 2021
test/unit/lib/aws/request.test.js
Outdated
| @@ -246,7 +271,10 @@ describe('#request', () => { | |||
| const awsRequest = proxyquire('../../../../lib/aws/request', { | |||
| 'aws-sdk': { S3: FakeS3 }, | |||
| }); | |||
| return expect(awsRequest({ name: 'S3' }, 'error')).to.be.rejected; | |||
| return expect(awsRequest({ name: 'S3' }, 'test')).to.eventually.be.rejected.and.have.property( | |||
There was a problem hiding this comment.
is return needed here? should it be marked as async and awaited?
There was a problem hiding this comment.
Technically it's needed if we do not await (and effect is same), but I agree that it's better to mark all promise returning functions as async, and to use await when we do not intend to return anything substantial.
I've updated those tests
pgrzesik
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9511