Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix projectDir pattern in config schema #9574

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix: Fix projectDir pattern in config schema #9574

merged 1 commit into from
Jun 8, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 8, 2021

Closes: #9573

@medikoo medikoo added the bug label Jun 8, 2021
@medikoo medikoo self-assigned this Jun 8, 2021
@medikoo medikoo mentioned this pull request Jun 8, 2021
Closed
@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited

Codecov Report

Merging #9574 (c79b5e8) into master (58f5215) will not change coverage.
The diff coverage is n/a.

❗ Current head c79b5e8 differs from pull request most recent head cfa2451. Consider uploading reports for the commit cfa2451 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9574   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files         322      322           
  Lines       12110    12110           
=======================================
  Hits        10484    10484           
  Misses       1626     1626
Impacted Files Coverage Δ
lib/configSchema.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f5215...cfa2451. Read the comment docs.

@medikoo medikoo force-pushed the 0608-fix-project-dir-pattern branch 2 times, most recently from 8efd2e0 to 0e4fa16 Compare June 8, 2021 13:01
@medikoo medikoo requested a review from pgrzesik June 8, 2021 13:11
@medikoo medikoo force-pushed the 0608-fix-project-dir-pattern branch from 0e4fa16 to cfa2451 Compare June 8, 2021 13:12
pgrzesik
pgrzesik approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 8954b5f into master Jun 8, 2021
@medikoo medikoo deleted the 0608-fix-project-dir-pattern branch June 8, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrzesik pgrzesik pgrzesik approved these changes

Assignees

@medikoo medikoo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration error at 'projectDir': should match pattern "/^(\.\/?|(\.\/)?\.\.(\/\.\.)*\/?)$/"
2 participants
@medikoo @pgrzesik