Allow to disable default export names #9748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrzesik
added
enhancement
deprecation
Codecov Report
@@ Coverage Diff @@
## master #9748 +/- ##
==========================================
+ Coverage 86.09% 86.10% +0.01%
==========================================
Files 327 328 +1
Lines 12582 12597 +15
==========================================
+ Hits 10832 10847 +15
Misses 1750 1750
Continue to review full report at Codecov.
|
medikoo
suggested changes
Jul 15, 2021
| @@ -63,6 +63,7 @@ provider: | |||
| key1: value1 | |||
| key2: value2 | |||
| deploymentPrefix: serverless # The S3 prefix under which deployed artifacts should be stored. Default is serverless | |||
| disableDefaultOutputExportNames: true # optional, allows to disable default behavior of generating export names for CloudFormation outputs | |||
There was a problem hiding this comment.
We should reflect default here, which while being null, is better to communicate with false (we do like that in other similar cases)
There was a problem hiding this comment.
good suggestion, thank you
pgrzesik
force-pushed
the
allow-disabling-automatic-export
branch
from
2d70cbe
to
7593d5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9361