Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: Unconditionally deprecate old vars engine extensions #9827

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Aug 11, 2021

When investigating code I've noticed a weird not logical condition which is expected to lead to deprecation when external plugin attempts to provide a new source for old variables engine.

This patch fixes that

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #9827 (4889d08) into master (dc74f41) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 4889d08 differs from pull request most recent head 2979638. Consider uploading reports for the commit 2979638 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9827   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files         329      329           
  Lines       12804    12804           
=======================================
  Hits        11030    11030           
  Misses       1774     1774           
Impacted Files Coverage Δ
...riables/sources/resolve-external-plugin-sources.js 88.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc74f41...2979638. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik August 11, 2021 13:24
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@medikoo medikoo merged commit b7f4e08 into master Aug 11, 2021
@medikoo medikoo deleted the 0711-fix-vars-extension-deprecation branch August 11, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants