Skip to content

Commit

Permalink
feat: Do not return null as analyticsUrl for CI=true
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Expose analytics server URL unconditionally (and not just
in non-CI environments) It is breaking as it might impact how analytics
reporting works in older version of the Framework and might pollute data
with unexpected events coming from CI deployments. Additonally, it will
cause notifications to be triggered in CI environments as well.
  • Loading branch information
pgrzesik committed Mar 11, 2021
1 parent 41cd2c1 commit 9f7143e
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions analytics-and-notfications-url.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ if (process.env.SLS_ANALYTICS_URL) {
return;
}

if (process.env.CI) {
module.exports = null;
return;
}

const isInChina = require('./is-in-china');

module.exports = isInChina
Expand Down

0 comments on commit 9f7143e

Please sign in to comment.