Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Additional updates up to changes in implemented new indentity system #167

Merged
merged 3 commits into from May 6, 2022

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented May 6, 2022

  • Support providing clientVersion param to browser
  • Update up to changed API spec
  • Support refreshToken rotation by accepting returned new token from auth/tokens/refresh endpoint

@medikoo medikoo added the enhancement New feature or request label May 6, 2022
@medikoo medikoo self-assigned this May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #167 (f329b41) into main (d699e52) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   88.37%   88.42%   +0.05%     
==========================================
  Files          25       25              
  Lines         671      674       +3     
==========================================
+ Hits          593      596       +3     
  Misses         78       78              
Impacted Files Coverage Δ
auth/login.js 64.47% <100.00%> (+1.45%) ⬆️
auth/resolve-id-token.js 71.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d699e52...f329b41. Read the comment docs.

@medikoo medikoo merged commit 7037a60 into main May 6, 2022
@medikoo medikoo deleted the 0506-auth-supplements branch May 6, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant