Remove Serverless: prefix from inquirer
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 9 9
Lines 226 226
=======================================
Hits 207 207
Misses 19 19
Continue to review full report at Codecov.
|
pgrzesik
commented
May 12, 2021
| const BasePrompt = require('inquirer/lib/prompts/base'); | ||
| const originalGetQuestion = BasePrompt.prototype.getQuestion; | ||
| BasePrompt.prototype.getQuestion = function () { | ||
| this.opt.prefix = 'Serverless:'; | ||
| this.opt.prefix = ''; |
There was a problem hiding this comment.
Overriding to empty string because by default it's equal to chalk.green('?')
medikoo
reviewed
May 12, 2021
| const BasePrompt = require('inquirer/lib/prompts/base'); | ||
| const originalGetQuestion = BasePrompt.prototype.getQuestion; | ||
| BasePrompt.prototype.getQuestion = function () { | ||
| this.opt.prefix = 'Serverless:'; | ||
| this.opt.prefix = ''; |
There was a problem hiding this comment.
Maybe let's add comment, that we're overriding ?, otherwise it looks obsolete
BREAKING CHANGE: Inquirer prompt will have no prefix instead of `Serverless:` If you wish, to still use `Serverless:` prefix, override it on the client side.
pgrzesik
force-pushed
the
remove-inquirer-prompt-prefix
branch
from
d58c637
to
59b2662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Inquirer prompt will have no prefix instead of
Serverless:If you wish, to still use
Serverless:prefix, override it on the client side.Related to: serverless/serverless#9367