Add download util
#84
Conversation
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 91.59% 90.07% -1.53%
==========================================
Files 9 10 +1
Lines 226 282 +56
==========================================
+ Hits 207 254 +47
- Misses 19 28 +9
Continue to review full report at Codecov.
|
| @@ -0,0 +1,3 @@ | |||
| ## Download | |||
|
|
|||
| Functionality adapted from currently unmaintained `download` package: https://github.com/kevva/download | |||
There was a problem hiding this comment.
It'll be good to clarify why we did that, and explain how issue was fixed (was upgrade of got good enough`?)
Is issue we're introducing workaround for reported at download repository? If it is, it'll be good to link it, otherwise it'll be good to create report over there and link it here.
There was a problem hiding this comment.
That's a great call, I'll add all explanations and changeset to the documentation. There's an issue on the download repo side, where I posted a comment with our specific case: kevva/download#208
pgrzesik
force-pushed
the
add-download-util
branch
from
711fa2b
to
016deb0
Compare
Based on https://github.com/kevva/download and brought in due to outdated
gotdependency in original library which didn't property handle timeouts for streams, causinginteractive CLIflow to hang for the duration of the timeout.I've tried to change as little code as possible in the original module (hence I left a lot of promise-based code without refatoring to async) - tests had to be adjusted more due to the use of different testing framework in the original module.