Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(121): split inject state to separate file #123

Merged
merged 1 commit into from
Nov 16, 2022
Merged

fix(121): split inject state to separate file #123

merged 1 commit into from
Nov 16, 2022

Conversation

lsytj0413
Copy link
Collaborator

Signed-off-by: lsytj0413 511121939@qq.com

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

Fixed #121

@lsytj0413
Copy link
Collaborator Author

Hold by serverlessworkflow/specification#703

Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have this timeouts for a while, why is it dependent?

@lsytj0413
Copy link
Collaborator Author

we already have this timeouts for a while, why is it dependent?

Yes, base on v0.8 we can confirm the timeouts property is exists. We can merge this now.

@lsytj0413
Copy link
Collaborator Author

cc @ricardozanini PTAL

@ricardozanini
Copy link
Member

@lsytj0413 can you please rebase? I'm on PTO, so I have limited access to GH.

@lsytj0413
Copy link
Collaborator Author

@lsytj0413 can you please rebase? I'm on PTO, so I have limited access to GH.

done, PTAL

@ricardozanini
Copy link
Member

/lgtm

@github-actions github-actions bot added the lgtm label Nov 14, 2022
Signed-off-by: lsytj0413 <511121939@qq.com>
@ricardozanini ricardozanini merged commit 09942a6 into serverlessworkflow:main Nov 16, 2022
@lsytj0413 lsytj0413 deleted the fix-121 branch November 16, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move InjectState to an separate inject_state.go file
3 participants