Fixes unsupported AST kind *ast.InterfaceType on the custon AuthPrope… #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidesalerno I think it is ready now, fell free to use it to update your PR or review this one. :) |
spolti
commented
Feb 9, 2023
spolti
commented
Feb 9, 2023
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
…rties type Signed-off-by: Spolti <filippespolti@gmail.com>
|
@davidesalerno @ricardozanini can you please review? |
| // GetSecret ... | ||
| func (b *BaseAuthProperties) GetSecret() string { | ||
| return b.Secret | ||
| func (a *Auth) MarshalJSON() ([]byte, error) { |
There was a problem hiding this comment.
The current test covers this method?
There was a problem hiding this comment.
there are a few tests that covers it, e.g.:
https://github.com/serverlessworkflow/sdk-go/blob/main/parser/parser_test.go#L663
https://github.com/serverlessworkflow/sdk-go/blob/main/parser/parser_test.go#L600
ricardozanini
approved these changes
Feb 14, 2023
davidesalerno
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rties type
Signed-off-by: Spolti filippespolti@gmail.com
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):