Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codecov, fix currentProjectPath when running outside regular path #149

Merged

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Mar 7, 2023

What this PR does / why we need it:

  • We were failing to upload codecov artifacts due to the usage of a very old version in our pipeline
  • Testing locally via make test or go test would fail due to an assumption that the caller is from an IDE.

Special notes for reviewers:

  • How are you guys running these tests locally? Not sure how it was working on CI either.

…path

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
@ricardozanini ricardozanini merged commit 7ee93e0 into serverlessworkflow:main Mar 7, 2023
@ricardozanini ricardozanini deleted the upgrade-codecov-v3 branch March 7, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants