Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmarshal state.end when boolean #155

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

ribeiromiranda
Copy link
Collaborator

@ribeiromiranda ribeiromiranda commented Mar 8, 2023

Unmarshal state.end when boolean to follow the end specification

Sorry, use that PR, not use the #147

Signed-off-by: André R. de Miranda <andre@galgo.tech>
parser/parser_test.go Outdated Show resolved Hide resolved
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you please sign the DCO and the commits? https://stackoverflow.com/questions/13043357/git-sign-off-previous-commits

model/workflow.go Outdated Show resolved Hide resolved
model/util.go Outdated Show resolved Hide resolved
model/workflow.go Outdated Show resolved Hide resolved
Signed-off-by: André R. de Miranda <andre@galgo.tech>
Signed-off-by: André R. de Miranda <andre@galgo.tech>
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Copy link
Collaborator Author

What do you think of this last commit? Unmarshal Workflow.End direct without using a map

@ricardozanini ricardozanini merged commit d76e8d0 into serverlessworkflow:main Mar 9, 2023
@ribeiromiranda ribeiromiranda deleted the end branch March 9, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants