Fixes workflow event states unmarshalling methods

[andresmijares]

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Actually, there's a small bug preventing to have Event Switch State and Event Data State on the same definition, this creates a small case where the other of the states only works if they are placed certain way, it's not deterministic.

We are using the sdk but we had to fork it in order to make it work correctly, I think, others will benefit from it.

How to reproduce it.

Given this definition:

{
		"id": "testWorkflow",
		"name": "Validation Workflow Test",
		"version": "1.0",
		"specVersion": "0.7",
		"start": "Sample",
		"states": [
                       {
				"name": "Sample",
				"type": "switch",
				"dataConditions": [
				  {
					"condition": "${  .total > 10 }",
					"transition": "Sample2"
				  }
				]
		      },
                       {
				"name": "Sample2",
				"type": "switch",
				"eventConditions": [
					{						
                                                  "eventRef": "eventOne",
						"transition": "HandleEventFinishOne"
				  	},
					{
						"eventRef": "eventFinishTwo",
						"transition": "HandleEventFinishTwo"
				  	}
				]
			}
                 ]
}

This line it's causing that when trying to unmashalling Sample2, mapState is not cleared for the next loop iteration, so map[dataConditions] is not nil. This cause this line to be trigger wrongly, when there are 2 switch events and a Switch Event Database is place before the Switch Event.

Clearing mapState before the next iteration of the loop should solve the issue.

Please, let me know, if anything else is needed.

Special notes for reviewers:

Additional information (if needed):

[ricardozanini]

Hi! Thanks for this change. Can you please add a unit test to validate the unmarshaling? Many thanks!

[andresmijares]

@ricardozanini should be good now, I added a small case with both states and making sure it compiles which is the small issue I'm solving, you can quickly confirm the issue changing the code back to the original way and run the test. Let me know if something else is required ^^. Thank u!

[ricardozanini]

@andresmijares let me know if you need a new patch release.

[andresmijares]

@ricardozanini after the merge, that would be great! i've been using a fork of the project only cause this :)

[ricardozanini]

@ricardozanini after the merge, that would be great! i've been using a fork of the project only cause this :)

Actually, I'll upgrade the Go version and try to fix the CI. Something is not quite right. See #63

[ricardozanini]

@andresmijares, I've fixed all these CI bugs and dependencies problems here: #66

Can you please take a look and try that PR locally to see if it's fine on your side so I can merge it? We then rebase this and do a release.

[andresmijares]

@ricardozanini i just sourced this branch on my project and ran without problem (without considering the issues fixed in this PR)!

go version go1.18.3 darwin/amd64

Just in case

[ricardozanini]

@andresmijares can you rebase now that I've merged #63?

[andresmijares]

@ricardozanini done! thank you!

[andresmijares]

@ricardozanini last question, not related to the PR, is there any slack channel for ppl sharing ideas about this project?

[ricardozanini]

@ricardozanini last question, not related to the PR, is there any slack channel for ppl sharing ideas about this project?

Sure thing: https://cloud-native.slack.com/

Go to serverless-workflow-sdk channel and ping me there. I'm online during working hours.

[andresmijares]

@ricardozanini i need an invitation, could u send me one pls? email is github user, gmail, thanks!!

[ricardozanini]

@andresmijares, many thanks for this contribution. I'm releasing a new patch version this afternoon.

[ricardozanini]

@andresmijares, the slack channel is open. I tried to add you to the channel, but it has been disabled. IDK why. You should be able to join, nevertheless.

[andresmijares]

@ricardozanini i think it's disabled, i tried joining and it says i dont have an account and i need one :(

[ricardozanini]

You just have to create a free account, I believe.

[andresmijares]

it seems it is set as invited only, not public joining option

[ricardozanini]

@andresmijares try this https://communityinviter.com/apps/cloud-native/cncf

[andresmijares]

thank you!

[ricardozanini]

Worked?

[andresmijares]

yes sir!

[ricardozanini]

Great, I'll update our docs.