Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(*): fix unittest assert.NoError checks and msg #67

Merged
merged 1 commit into from
Sep 5, 2022
Merged

test(*): fix unittest assert.NoError checks and msg #67

merged 1 commit into from
Sep 5, 2022

Conversation

lsytj0413
Copy link
Collaborator

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

  • Fix the error message in unittest
  • always check assert.NoError returns, to avoid when error happened, subsequent sentences panic

Special notes for reviewers:

Additional information (if needed):

@lsytj0413
test(*): fix unittest assert.NoError checks and msg
db08938 
Signed-off-by: lsytj0413 <511121939@qq.com>
ricardozanini
ricardozanini approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Thank you!

@ricardozanini ricardozanini merged commit ddc15cc into serverlessworkflow:main Sep 5, 2022
@lsytj0413 lsytj0413 deleted the fix-ut-msgAndArgs branch September 5, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@tsurdilo tsurdilo Awaiting requested review from tsurdilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lsytj0413 @ricardozanini