v08 spec alignment - Workflow name no longer a required property #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spolti <filippespolti@gmail.com>
spolti
force-pushed
the
nameNotRequired
branch
from
f267ce2
to
49078f7
Compare
This was referenced Sep 27, 2022
Closed
ricardozanini
approved these changes
Sep 28, 2022
|
@lsytj0413 wanna take a look? |
lsytj0413
reviewed
Sep 28, 2022
lsytj0413
reviewed
Sep 28, 2022
| }, "./testdata/workflows/checkinbox.cron-test.sw.yaml": func(t *testing.T, w *model.Workflow) { | ||
| }, | ||
| "./testdata/workflows/checkinbox.cron-test.sw.yaml": func(t *testing.T, w *model.Workflow) { | ||
| assert.Equal(t, "Check Inbox Workflow", w.Name) |
There was a problem hiding this comment.
We should organize the testcase later, with all field assert？
There was a problem hiding this comment.
not sure what do you mean.
There was a problem hiding this comment.
Sorry for did not make it clear. Should we change the testcode to:
"./testdata/workflows/checkinbox.cron-test.sw.yaml": func(t *testing.T, w *model.Workflow) {
assert.Equal(t, expectWorkflowObject, w)
}
, maybe this is more effective, it can verify all of workflow fields.
Signed-off-by: spolti <filippespolti@gmail.com>
|
I think it is ready to merge. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spolti filippespolti@gmail.com
issue: #70
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):