Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): add v0.8 action data filter's condition field #83

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

brlala
Copy link
Contributor

@brlala brlala commented Sep 29, 2022

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
add condition statement for action

Special notes for reviewers:

Additional information (if needed):

Signed-off-by: LiHeng.Teh <Liheng.Teh@acronis.com>
@lsytj0413
Copy link
Collaborator

/lgtm

Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the sleep field is missing as well.

can you please add it?

@spolti spolti mentioned this pull request Sep 29, 2022
@spolti
Copy link
Member

spolti commented Sep 29, 2022

fixes: #70

@ricardozanini ricardozanini added this to the Spec 0.8 Support milestone Sep 29, 2022
@ricardozanini ricardozanini removed the request for review from tsurdilo September 29, 2022 14:12
@ricardozanini
Copy link
Member

Seems that the sleep field is missing as well.

can you please add it?

I think this PR is only to add the condition field and tests related to it.

@ricardozanini ricardozanini merged commit 9384e9a into serverlessworkflow:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants