Remove pointer map used to get AuthProperties #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinmclean
requested review from
tsurdilo and
ricardozanini
as code owners
Fixes serverlessworkflow#86 Signed-off-by: Calvin McLean <calvinlmc@gmail.com>
calvinmclean
force-pushed
the
fix/86/authproperties-pointers
branch
from
f57d7bf
to
f6b051e
Compare
spolti
approved these changes
Sep 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage ? 16.52%
=======================================
Files ? 14
Lines ? 575
Branches ? 0
=======================================
Hits ? 95
Misses ? 460
Partials ? 20
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Calvin McLean <calvinlmc@gmail.com>
calvinmclean
force-pushed
the
fix/86/authproperties-pointers
branch
from
bb66cfd
to
c481df1
Compare
ricardozanini
approved these changes
Oct 3, 2022
|
@ricardozanini would it be possible to get a new release version with this change? |
|
@calvinmclean we are currently implementing version 0.8 of the spec, so it's not a good moment for a release right now. Due to the nature of Go, can't you use the commit ID in go.mod instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #86
See issue for more details, but basically the pointer map used to get
AuthPropertiesbased onSchemecaused all parsed Workflows to reference the same property which does not allow unique tokens.Special notes for reviewers:
Additional information (if needed):