feat(action): add invoke/onParentComplete/Id field #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
reviewed
Oct 4, 2022
Signed-off-by: lsytj0413 <511121939@qq.com>
Closed
spolti
approved these changes
Oct 4, 2022
spolti
reviewed
Oct 4, 2022
|
|
||
| // Invoke specifies if the subflow should be invoked sync or async. | ||
| // Defaults to sync. | ||
| Invoke string `json:"invoke,omitempty" validate:"required,oneof=async sync"` |
There was a problem hiding this comment.
isn't better to have something like this:
Invoke InvokeKindjson:"invoke,omitempty" validate:"omitempty,min=1"`
There was a problem hiding this comment.
I'd like to define InvokeKind enum for this value, and it's will be fixed in another PR (it seems appear in other struct too).
If we use validate with min=1, we must add a custom validate function for this struct (at this moment, the validator's oneof tag satisfy our requirement, so i use it).
There was a problem hiding this comment.
Since Invoke is an enum, we need a type indeed.
ricardozanini
approved these changes
Oct 4, 2022
|
relates to #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lsytj0413 511121939@qq.com
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):