Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmd + K to support Firefox & Windows #107

Open
danpastori opened this issue Sep 13, 2024 · 0 comments
Open

Update cmd + K to support Firefox & Windows #107

danpastori opened this issue Sep 13, 2024 · 0 comments
Assignees

Comments

@danpastori
Copy link
Contributor

Current Behavior

cmd + K search doesn't operate as expected in Firefox or on Windows machines

Expected Behavior

Pressing cmd + k to search should bring up the docs search

Steps To Reproduce

Press cmd + k to search

Environment

N/A

Anything else?

Problem
cmd + K in Firefox jumps to the search bar within the browser and not within Spin

Solution
https://github.com/jaywcjlove/hotkeys-js

Utilizing hotkeys.js can prevent the default commands from running scoping the cmd + k to Spin. We should also support ctrl + k for Windows machines

@danpastori danpastori self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant