Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITE] Implementation of Dashboard Page #309

Merged
merged 3 commits into from Apr 4, 2022

Conversation

asubedy
Copy link
Member

@asubedy asubedy commented Apr 4, 2022

Signed-off-by: asubedy frexpe@pm.me

Description
This PR will help in tracking the progress of the SMP Benchmark Dashboard page.

This PR updates #272

Notes for Reviewers
This is the basic structure on how the page is going to look, any feedback comments are welcome.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: asubedy <frexpe@pm.me>
@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for smp-spec ready!

Name Link
🔨 Latest commit 761003f
🔍 Latest deploy log https://app.netlify.com/sites/smp-spec/deploys/624b71af6a5a880008970726
😎 Deploy Preview https://deploy-preview-309--smp-spec.netlify.app/benchmark
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: asubedy <frexpe@pm.me>
@leecalcote
Copy link
Member

@theBeginner86, batter up.

@leecalcote
Copy link
Member

Drop an empty state in to the position for where live charts will be shown and we're good to merge, @asubedy

@leecalcote leecalcote requested a review from a team April 4, 2022 18:27
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait... the lack of reuse in this PR is no bueno. Use includes and layouts, please.

@asubedy
Copy link
Member Author

asubedy commented Apr 4, 2022

Wait... the lack of reuse in this PR is no bueno. Use includes and layouts, please.

Done, now the page is displayed using dashboardPage layout. // @leecalcote

@asubedy
Copy link
Member Author

asubedy commented Apr 4, 2022

Drop an empty state in to the position for where live charts will be shown and we're good to merge, @asubedy

Done ✅ . Added an image from Meshery UI of a dummy performance test result.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid start.

@leecalcote leecalcote merged commit 2a3a23a into service-mesh-performance:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants