New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SITE] Implementation of Dashboard Page #309
Conversation
Signed-off-by: asubedy <frexpe@pm.me>
✅ Deploy Preview for smp-spec ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: asubedy <frexpe@pm.me>
@theBeginner86, batter up. |
Drop an empty state in to the position for where live charts will be shown and we're good to merge, @asubedy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait... the lack of reuse in this PR is no bueno. Use includes
and layouts
, please.
Signed-off-by: asubedy <frexpe@pm.me>
Done, now the page is displayed using |
Done ✅ . Added an image from Meshery UI of a dummy performance test result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a solid start.
Signed-off-by: asubedy frexpe@pm.me
Description
This PR will help in tracking the progress of the SMP Benchmark Dashboard page.
This PR updates #272
Notes for Reviewers
This is the basic structure on how the page is going to look, any feedback comments are welcome.
Signed commits