-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated UI fixed layout of Blogs and Engage Components #395
Updated UI fixed layout of Blogs and Engage Components #395
Conversation
✅ Deploy Preview for smp-spec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the uniformity of cards @mayurjadhav2002, One small change, the hover effect on the post cards instead of the content being scaled up let's make the entire card pop up similar to Resources cards.
Hey Hii, @asubedy I just completed the changes you mentioned. I wanted to ask you, should I remove that green eye on blog cards that can be seen on hover? because we are scaling the card itself. |
Let's discuss it on the websites call. |
@sudhanshutech tried to open the link, but getting "Access Denied". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayurjadhav2002 looks great one small problem
Screen.Recording.2023-08-14.at.19.48.43.mov
In this recording you can see the text getting wrapped up onto next line while hovering. This doesn't look good. I guess only having the card popup on hover is good without the text getting wrap onto next line.
@asubedy Hey, thanks for the review, I've applied the changes. also, I want to mention that I have found a new issue on the dashboard page the performance profile table which shows results is not responsive. take a look at the below screenshots. On Mobile or Small screen devices On mobile, it is just showing the profile and endpoints. It is not horizontally scrollable to see other information. Thanks and Regards! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayurjadhav2002 The same text wrapping effect can be seen in the engage cards too, could you change that too.
@mayurjadhav2002 regarding the dashboard change .YES! that needs a fix you can go ahead and make issue for this and I will assign it to you. |
@asubedy I have removed the text wrapping effect from engage cards. please let me know if there are any more changes required. in the meantime, I will open a new issue regarding the dashboard page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @mayurjadhav2002 🚀
64c7f15
Description
This PR fixes issue #392, the website UI now has fixed height and width for blog components as well as for the resources cards (Engage Component).
Updated UI
Before Updating
Notes for Reviewers
Signed commits