Always use correct tool version #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use go dependency management to download and run common build tools like controller-gen, ginkgo and kustomize. This will ensure that the correct version of the tool is used. As a bonus, we can use tools like dependabot to automatically track and propose updated to our tools. Under the hood this works by using a custom go module with a single dependency (the tool). `go run` is used to load and execute the tool at runtime for that module. Golang caches the compiled version of the tool and invalidates the cache when a new version of the tool is desired. This PR does not change how envtest is setup, which is a bit more complicated. This PR also aligns the module name with the git repo. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use go dependency management to download and run common build tools like
controller-gen, ginkgo and kustomize. This will ensure that the correct
version of the tool is used. As a bonus, we can use tools like
dependabot to automatically track and propose updated to our tools.
Under the hood this works by using a custom go module with a single
dependency (the tool).
go runis used to load and execute the tool atruntime for that module. Golang caches the compiled version of the tool
and invalidates the cache when a new version of the tool is desired.
This PR does not change how envtest is setup, which is a bit more
complicated.
This PR also aligns the module name with the git repo.
Signed-off-by: Scott Andrews andrewssc@vmware.com