Use ko to build container image #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ko` is a tool that can build and deploy k8s resources that reference go paths which are build and transparently substituted into the resulting resources. ko works by finding `ko://` references in the k8s yaml that point at a go compile target, the built binary is placed into the base image and pushed to an image registry specified by the KO_DOCKER_REPO env var. A digested reference to the pushed image is substituted into the yaml replacing the `ko://...` reference. https://github.com/google/ko In this case, we can replace direct dependencies on the kubectl and docker CLIs and the Docker daemon. ko also makes it much easier to produce multi-platform/architecture images for which there is a compatible base image (gcr.io/distroless/static:nonroot by default) and can be cross compiled by go. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
baijum
reviewed
Aug 19, 2021
| @@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.4.1 | |||
| controller-gen.kubebuilder.io/version: v0.6.2 | |||
There was a problem hiding this comment.
This is an unrelated change, right?
I think we need a check in the CI to ensure make generate and make manifests commands are run.
For now, let this change go with this PR.
There was a problem hiding this comment.
Created PR to add the check: #20
baijum
reviewed
Aug 19, 2021
| @@ -67,23 +63,16 @@ build: generate fmt vet ## Build manager binary. | |||
| run: manifests generate fmt vet ## Run a controller from your host. | |||
| go run ./main.go | |||
|
|
|||
| docker-build: test ## Build docker image with the manager. | |||
| docker build -t ${IMG} . | |||
There was a problem hiding this comment.
Do we need an equivalent ko command to build an image here?
There was a problem hiding this comment.
ko apply will:
- build images
- publish images to the registry
- substitute the image into the yaml
- apply the yaml to the cluster
There was a problem hiding this comment.
Ok 👍
I am new to this tool. Thanks for the explanation.
baijum
reviewed
Aug 19, 2021
| docker build -t ${IMG} . | ||
|
|
||
| docker-push: ## Push docker image with the manager. | ||
| docker push ${IMG} |
There was a problem hiding this comment.
Do we need an equivalent ko command to push the image here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kois a tool that can build and deploy k8s resources that referencego paths.
https://github.com/google/ko
ko works by finding
ko://references in the k8s yaml that point at ago compile target, the built binary is placed into the base image and
pushed to an image registry specified by the KO_DOCKER_REPO env var. A
digested reference to the pushed image is substituted into the yaml
replacing the
ko://...reference.In this case, we can replace direct dependencies on the kubectl and
docker CLIs and the Docker daemon. ko also makes it much easier to
produce multi-platform/architecture images for which there is a
compatible base image (gcr.io/distroless/static:nonroot by default) and
can be cross compiled by go.
Signed-off-by: Scott Andrews andrewssc@vmware.com