Keep kube-rbac-proxy images up to date #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubebuilder includes a kube-rbac-proxy sidecar with the controller deployment, but provides no mechanism to keep that image up to date. We now use dependabot to consume new upstream releases of the proxy go module, and build that source into an image as part of `make deploy` and the regular CI release via `ko`. Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 65.88% 65.88%
=======================================
Files 33 33
Lines 1618 1618
=======================================
Hits 1066 1066
Misses 479 479
Partials 73 73 ☔ View full report in Codecov by Sentry. |
sadlerap
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubebuilder includes a kube-rbac-proxy sidecar with the controller deployment, but provides no mechanism to keep that image up to date.
We now use dependabot to consume new upstream releases of the proxy go module, and build that source into an image as part of
make deployand the regular CI release viako.Resolves #424