-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should we be using CRD openapi v3 schema validation for the status section #6
Comments
hey @huizengaJoe - I really like the idea of having an operator-sdk scorecard test that would check for spec compliancy. Is that something we could contribute somewhere? I am not sure if that necessarily means something in the OAS3 schema, since from what I have seen that's mostly to validate |
hey @huizengaJoe - for your first point, I believe that will get addressed by PR #9 - please feel free to add comments there. |
@arthurdm Is this issue still valid for the current state of the specification? |
@nebhale it's stale since the CRD instance (which contains the schema) needs to be provided by the implementation. |
I guess the valid question is: should the spec provide a CRD for |
As in a reference implementation Go library? |
I was thinking just the CRD itself, since we may have non-Go implementations. |
What concrete artifacts do you think this should be then? Just an OpenAPI schema definition? |
I was thinking the full CRD, including the OAS3 portion. Before the restructure of the spec we were pointing to this CRD, which was nice in terms of having a concrete CRD that implementations could share. Was looking for something equivalent. |
The CRD definition is inextricably linked to the implementation since the versions |
ya, if >90% of the CRD will be the same, would be nice to provide it in the spec. |
OK, I'll start work on a PR for an exemplar CRD. |
This change contributes an exemplar CRD for the ServiceBinding as it stands in the specification today. This document should be kept up to date as the spec is updated. [resolves #6] Signed-off-by: Ben Hale <bhale@vmware.com>
Does it make sense to use CRD openapi v3 schema validation for the status section as a way to enforce consistency in naming the binding items?
It would be great if we had a way to:
Thoughts?
The text was updated successfully, but these errors were encountered: