Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concept citadel #313

Merged
merged 3 commits into from Sep 1, 2020
Merged

Add concept citadel #313

merged 3 commits into from Sep 1, 2020

Conversation

malphi
Copy link
Contributor

@malphi malphi commented Sep 1, 2020 •
edited

提交 PR 前请先自查以下内容：

在完成项的 [ ] 内填入 x，如：- [x]

  • 我认可本书的版权信息：本书著作权归属于 ServiceMesher 社区，我将保留对所修改内容的署名权。
  • 我已阅读参与贡献说明，并加入了 istio-handbook-wg GitHub team。
  • 我已修改 PR 的标题格式（新增内容 PR 的标题格式为：add: 文档标题，修改已有内容 PR 的标题格式为 update：文档标题）。
  • 我已在该 PR 已指明解决的 issue 链接：issue#63。
  • 我已参考 PR#186 文章内容的格式。
  • 我已阅读并保证所提交 PR 符合写作规范。

@netlify
Copy link

netlify bot commented Sep 1, 2020 •
edited

Deploy preview for elated-johnson-d0b7ca ready!

Built with commit a826e97

https://deploy-preview-313--elated-johnson-d0b7ca.netlify.app

@mergify mergify bot requested a review from a team September 1, 2020 03:52
rootsongjc
rootsongjc reviewed Sep 1, 2020
View reviewed changes
concepts/citadel.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team September 1, 2020 05:43
rootsongjc
rootsongjc approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@mergify mergify bot merged commit f2cb57c into servicemesher:master Sep 1, 2020
@mergify mergify bot requested a review from a team September 1, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootsongjc rootsongjc rootsongjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malphi @rootsongjc