Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let CI only check changed files #282

Merged
merged 2 commits into from
May 13, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented May 10, 2019

升级 circleci ,仅检查变更的 markdown 文件

暂时将 spell check 设置为弱检查(只检查,不阻止合并),因为很多单词不在术语表中。
最棘手的是,每篇文章都有原作者信息,人名往往不是标准单词,不能每篇文章都修改 .spelling 文件。

/cc @rootsongjc @haiker2011

@auto-comment
Copy link

auto-comment bot commented May 10, 2019

Thank you for raising the pull request. We will review it as soon as possible.
To ensure document quality, we have enabled the CI test, which currently includes spell and format checks. If your pull request fails to pass the spell check, but you are sure that the word(s) is/are correct, feel free to add the word(s) into our glossary .spelling.
😆

@SataQiu SataQiu changed the title let CI only check changed files Let CI only check changed files May 10, 2019
@SataQiu SataQiu force-pushed the only-check-changed-files branch 6 times, most recently from 462dd52 to fcb3cd9 Compare May 10, 2019 11:39
@@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: gcr.io/istio-testing/website-builder:2019-03-31
- image: shidaqiu/servicemesher-trans-circleci:1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个镜像的代码和 Dockerfile 在哪能看到?

@haiker2011 haiker2011 assigned SataQiu and unassigned shaobai May 12, 2019

RUN apk add --no-cache bash git curl jq

Run apk add --no-cache nodejs-current-npm && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run->RUN

@haiker2011
Copy link
Member

/lgtm

@haiker2011 haiker2011 merged commit 8f73fa6 into servicemesher:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants