This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Allow edges queries to see cross-namespace edges #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
Pothulapati
approved these changes
Mar 11, 2020
grampelberg
approved these changes
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linkerd edge queries in Prometheus have the label constraint that "namespace" must match the resource namespace. The "namespace" Prometheus label refers to the label of the source resource. In the case of a "from" edge, the source resource might be in a different namespace and therefore get excluded by this query.
We distinguish between the "namespace" (source) and "toNamespace" (destination) to properly include all "from" edges, even from resources in other namespaces.
Signed-off-by: Alex Leong alex@buoyant.io