Avoid decoding empty buffers

serviejs · Jun 10, 2018 · 8c28fcf · 8c28fcf
1 parent 9046264
commit 8c28fcf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/index.spec.ts b/src/index.spec.ts
@@ -22,6 +22,12 @@ describe('keysign', () => {
     expect(result).toEqual(undefined)
   })
 
+  it('should fail to decode empty buffer', () => {
+    const result = keysign.decode(Buffer.alloc(0))
+
+    expect(result).toEqual(undefined)
+  })
+
   it('should verify the hmac is correct', () => {
     const signed = keysign.encode(Buffer.from('example', 'utf8'))
 

diff --git a/src/index.ts b/src/index.ts
@@ -74,6 +74,8 @@ export class Keysign {
   }
 
   decode (data: Buffer): Buffer | undefined {
+    if (!data.length) return undefined
+
     const index = data.readUInt8(0)
     const algorithm = ALGORITHMS[index]