This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Implement NSWindowStyleMask as bitflags #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and is therefore bitwise-combinable, though it loses type information. Instead of implementing NSWindowMask as a packed-data object with a u64 representational form, we ought to employ bit flags to generate a strong type that remains combinable in the manner Cocoa programmers are accustomed to. Also easier than manually implementing std::ops::BitOr for the type.
jdm
suggested changes
Mar 22, 2017
src/appkit.rs
Outdated
| msg_send![self, styleMask] | ||
| unsafe fn styleMask(self) -> NSWindowMask { | ||
| let styleMask = msg_send![self, styleMask]; | ||
| styleMask |
There was a problem hiding this comment.
I'm surprised that this works as written. Doesn't this need to call NSWindowMask::from_bits or from_bits_truncate?
There was a problem hiding this comment.
from_bits_truncate would add a nice validity check. I'll add that in.
There was a problem hiding this comment.
Done. Also renamed NSWindowMask to NSWindowStyleMask to match AppKit.
…nd maps to declared fields. Prefer truncate because macOS may use reserved bits for private purposes, or introduce new values in future versions.
|
@bors-servo: r+ |
|
📌 Commit 135fce2 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 22, 2017
Implement NSWindowStyleMask as bitflags RE #159 `NSWindowStyleMask`, as an enumeration in Objective-C, degrades to `NSUInteger` and is therefore bitwise-combinable, though it loses type information. Instead of implementing `NSWindowStyleMask` as a packed-data object with a `u64` representational form, we ought to employ bit flags to generate a strong type that remains combinable in the manner Cocoa programmers are accustomed to. Also easier than manually implementing `std::ops::BitOr` for the type. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/cocoa-rs/160) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
Example needs to be updated now: |
|
Yeah, saw the message from bors-servo. Was at lunch; committing now. Thanks @jdm. |
|
@bors-servo: r+ |
|
📌 Commit e773703 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 22, 2017
Implement NSWindowStyleMask as bitflags RE #159 `NSWindowStyleMask`, as an enumeration in Objective-C, degrades to `NSUInteger` and is therefore bitwise-combinable, though it loses type information. Instead of implementing `NSWindowStyleMask` as a packed-data object with a `u64` representational form, we ought to employ bit flags to generate a strong type that remains combinable in the manner Cocoa programmers are accustomed to. Also easier than manually implementing `std::ops::BitOr` for the type. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/cocoa-rs/160) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE #159
NSWindowStyleMask, as an enumeration in Objective-C, degrades toNSUIntegerand is therefore bitwise-combinable, though it loses type information. Instead of implementingNSWindowStyleMaskas a packed-data object with au64representational form, we ought to employ bit flags to generate a strong type that remains combinable in the manner Cocoa programmers are accustomed to. Also easier than manually implementingstd::ops::BitOrfor the type.This change is