Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for matrix decomposition #335

Open
Manishearth opened this issue Apr 8, 2019 · 6 comments
Open

Add support for matrix decomposition #335

Manishearth opened this issue Apr 8, 2019 · 6 comments

Comments

@Manishearth
Copy link
Member

Servo has code for this already, but I think it's written for column vector matrices since that's what css-transforms uses

I need this for XR stuff anyway and both Gecko and Chromium have 3d and 2d matrix decompositions in their libraries. It would be nice if Servo could use an implementation from euclid for both the CSS stuff as well as XR stuff.

@nical
Copy link
Contributor

nical commented Apr 9, 2019

Sounds good to me! Euclid already has a few equivalents for some of the types in this file, and there is the question of whether we want to sort out the column/vector story before or implement this with row vectors instead, but other than that I'm game for moving this implementation here.

@Manishearth
Copy link
Member Author

I would like to sort out the column/row story first but this also may require sorting it out on the gecko side as well :/

@nical
Copy link
Contributor

nical commented Apr 9, 2019

Yeah, the gecko side isn't necessarily more work than servo. Needs to be investigated though.

@Manishearth
Copy link
Member Author

Manishearth commented Apr 9, 2019 via email

@nical
Copy link
Contributor

nical commented Apr 12, 2019

I currently don't have the bandwidth to delve into the gecko side.

@Manishearth
Copy link
Member Author

Manishearth commented Apr 13, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants