Make euclid types repr(C). #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Feb 7, 2017
| @@ -33,6 +33,7 @@ use std::fmt; | |||
| /// another. See the `ScaleFactor` docs for an example. | |||
| // Uncomment the derive, and remove the macro call, once heapsize gets | |||
| // PhantomData<T> support. | |||
| #[repr(C)] | |||
| #[derive(RustcDecodable, RustcEncodable)] | |||
| pub struct Length<T, Unit>(pub T, PhantomData<Unit>); | |||
There was a problem hiding this comment.
Note that this is safe, even though rustc will complain about it until rust-lang/rust#39462 lands.
Also, note that depending of the size of T, being Length a struct but T an integer/floating point value, passing Length as an argument instead of T may break the ABI in 32bit linux, etc, see the last comments in rust-lang/rfcs#1758.
I don't think you're going to pass Length directly through, right?
| @@ -14,6 +14,7 @@ macro_rules! define_matrix { | |||
| $(pub $field:ident: T,)+ | |||
| } | |||
| ) => ( | |||
| #[repr(C)] | |||
| $(#[$attr])* | |||
| pub struct $name<T, $($phantom),+> { | |||
| @@ -36,6 +36,7 @@ use std::marker::PhantomData; | |||
| /// let one_foot: Length<f32, Inch> = Length::new(12.0); | |||
| /// let one_foot_in_mm: Length<f32, Mm> = one_foot * mm_per_inch; | |||
| /// ``` | |||
| #[repr(C)] | |||
| #[derive(RustcDecodable, RustcEncodable)] | |||
| pub struct ScaleFactor<T, Src, Dst>(pub T, PhantomData<(Src, Dst)>); | |||
There was a problem hiding this comment.
And ditto again, similarly to Length.
|
@bors-servo r+ |
|
📌 Commit 70ae01e has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 7, 2017
Make euclid types repr(C). This will facilitate exposing euclid types through ffi. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/176) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will facilitate exposing euclid types through ffi.
This change is