Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Size3D::is_empty(). #517

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix Size3D::is_empty(). #517

merged 1 commit into from
Mar 4, 2024

Conversation

kpreid
Copy link
Contributor

@kpreid kpreid commented Feb 29, 2024

It processed the depth coordinate backwards and would therefore usually return false.

@kpreid
Fix Size3D::is_empty().
5023dd1 
It processed the depth coordinate backwards and would therefore usually
return false.
@kpreid kpreid changed the title Fix Size3D::empty(). Fix Size3D::is_empty(). Feb 29, 2024
nical
nical approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

@nical nical added this pull request to the merge queue Mar 4, 2024
@nical
Copy link
Contributor

nical commented Mar 4, 2024

Thanks!

Merged via the queue into servo:master with commit 535f6e1 Mar 4, 2024
19 checks passed
@nical nical mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical nical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kpreid @nical