Reset char size even if bitmap buffer is null #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting incorrect bounds for glyphs after rasterizing the
space(' ') glyph.
In rasterize_glyph(), there is an early return if the bitmap buffer is
null (as it is a space) and because of that the char size is not reset
correctly. Then if you call raster_bounds for another glyph it loads it
with the rasterize char size.
mrobinson
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting incorrect bounds for glyphs after rasterizing the space(' ') glyph.
In rasterize_glyph(), there is an early return if the bitmap buffer is null (as it is a space) and because of that the char size is not reset correctly.
Then if you call raster_bounds for another glyph it loads it with the rasterize char size.
So I just removed the early return and add an else block, so the reset is called at the end.