Link against libc++ on OpenHarmony OS
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenHarmony OS is built with clang and should link against `libc++` and not `libstdc++`. A better medium term solution would probably be to ditch `cmake-rs` and instead use `cc-rs` which would automatically emit the correct `rustc-link-lib` line based on the compiler and certain environment variables.
|
@mrobinson Perhaps you could review this? |
mrobinson
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenHarmony OS is built with clang and should link against
libc++and notlibstdc++.A better medium term solution would probably be to ditch
cmake-rsand instead usecc-rswhich would automaticallyemit the correct
rustc-link-libline based on the compiler and certain environment variables.