Remove cmake dependency
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use cc-rs for the build of the native libraries. This removes the dependency on `cmake`, which hopefully solves the following issues: - `cc-rs` will link to the correct C++ stdlib depending on the compiler and the `CXXSTDLIB` / `CXXSTDLIB_$target` variables. Our buildscript previously only had a very simple target-based approach. - Fix random cases when cross-compiling (e.g. to -ohos), where the `CMakeCache.txt`would contain the default host compiler and not respect the CMake toolchain file. This only happened when recompiling, and might involve a race depending on when exactly the parent servo compilation failed.
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
force-pushed
the
jschwender/use-cc-rs
branch
from
4f16e7c
to
f7d59b0
Compare
|
CC @mrobinson it seems that |
mrobinson
reviewed
Mar 21, 2024
mrobinson
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cc-rs for the build of the native libraries.
This removes the dependency on
cmake, which hopefully solves thefollowing issues:
cc-rswill link to the correct C++ stdlib depending on the compilerand the
CXXSTDLIB/CXXSTDLIB_$targetvariables. Our buildscriptpreviously only had a very simple target-based approach.
CMakeCache.txtwould contain the default host compiler and notrespect the CMake toolchain file.
This only happened when recompiling, and might involve a race
depending on when exactly the parent servo compilation failed.