Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unassign to hivefive #199

Closed
tigercosmos opened this issue Jan 7, 2018 · 9 comments
Closed

add unassign to hivefive #199

tigercosmos opened this issue Jan 7, 2018 · 9 comments

Comments

@tigercosmos
Copy link

we can assign ourselves, but we can't unassign later when we find cannot handle the issue.

@KiChjang
Copy link
Contributor

KiChjang commented Jan 7, 2018

I'm unclear on the benefits of this would have over commenting "please unassign me from this issue" and then have a reviewer remove the tag.

@tigercosmos
Copy link
Author

yeah. We can let reviewer to do that. But if the bot can do, why not? :)

@KiChjang
Copy link
Contributor

KiChjang commented Jan 8, 2018

Because the bot cannot do what you think it does, the label does not carry any information about who said @highfive assign me before, and if you implement it naively, the bot would just remove the label whenever someone comments @highfive unassign me.

@tigercosmos
Copy link
Author

@KiChjang You are right ..
This still can be solve by checking comment above, but it will be too complicated.

@wafflespeanut
Copy link
Contributor

wafflespeanut commented Jan 10, 2018

@tigercosmos This would be an interesting feature for the new highfive (which tracks assignees). I've opened it there :)

@tigercosmos
Copy link
Author

@wafflespeanut Ah! What's the new highfive?
Will it replace the current one soon?

@wafflespeanut
Copy link
Contributor

wafflespeanut commented Jan 10, 2018

@tigercosmos It was planned for a replacement last year, but it's currently being blocked on an issue with Github itself. Once that's resolved, we'll probably switch to it :)

I also need to clean it up a bit - right now, it's a giant monolithic hog'ish nightmare which just works.

@tigercosmos
Copy link
Author

I see. Once it launch, I would like to contribute on it. :)

@wafflespeanut
Copy link
Contributor

Sure thing!

Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants