This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Allow multiple types of builders #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
changed the title
This was referenced Mar 5, 2016
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Mar 5, 2016
Make appveyor run on auto branch Don't merge yet, needs servo/homu#13
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Mar 5, 2016
Make appveyor run on auto branch Don't merge yet, needs servo/homu#13 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9884) <!-- Reviewable:end -->
|
cc @barosl I'd love to upstream this to homu main later, but I figured you'd like to see it get some mileage on the Servo side first 😄 |
|
Anyway, this seems to work, both on servo, and on travis repos. |
|
Reviewed 3 of 3 files at r1. Comments from the review on Reviewable.io |
|
@bors-servo r+ |
larsbergstrom
added a commit
that referenced
this pull request
Mar 5, 2016
Allow multiple types of builders
bors-servo
pushed a commit
to servo/saltfs
that referenced
this pull request
Mar 5, 2016
Add appveyor support for servo's homu Don't merge yet, needs servo/homu#13 to merge and then a bump in the homu SHA r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/232) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/saltfs
that referenced
this pull request
Mar 5, 2016
Add appveyor support for servo's homu Don't merge yet, needs servo/homu#13 to merge and then a bump in the homu SHA r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/232) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/saltfs
that referenced
this pull request
Mar 5, 2016
Add appveyor support for servo's homu Don't merge yet, needs servo/homu#13 to merge and then a bump in the homu SHA r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/232) <!-- Reviewable:end -->
kennytm
pushed a commit
to kennytm/homu
that referenced
this pull request
Mar 31, 2019
Output structured comments for build events Co-authored-by: <kennytm@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently works for travis-enabled repos, I have not tried it yet with Servo (but it looks like it should just work).
It temporarily disables the travis-exemption feature in homu, since we don't use it. I'll fix it up in a bit. (If we want to use it, we have to switch the
[repo.foo.travis]sections with[repo.foo.status.travis] context = 'continuous-integration/travis-ci/push')To work, it needs servo/servo#9884 on Servo, and servo/saltfs#232 on saltfs.
The
/githubhook for any repo that wants to use this needs to be updated so that it sends the "status" event type.cc @larsbergstrom