Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(local_names): add missing ARIA attributes #536

Merged
merged 1 commit into from Apr 16, 2024

Conversation

nolanlawson
Copy link
Contributor

@nolanlawson nolanlawson commented Apr 14, 2024

As part of implementing ARIAMixin (servo/servo#32079), it seems that, as a first step, html5ever would need to update its list of ARIA attributes in local_names.txt to correspond to those defined in ARIAMixin.

(If html5ever does not have these attributes defined in local_names.txt, then changes to element.rs such as this fail to compile.)

This PR adds the missing ARIA attributes:

  • aria-braillelabel
  • aria-brailleroledescription
  • aria-colcount
  • aria-colindex
  • aria-colindextext
  • aria-colspan
  • aria-current
  • aria-description
  • aria-details
  • aria-errormessage
  • aria-keyshortcuts
  • aria-label
  • aria-modal
  • aria-orientation
  • aria-placeholder
  • aria-roledescription
  • aria-rowcount
  • aria-rowindex
  • aria-rowindextext
  • aria-rowspan
  • aria-valuetext

However, I did not remove the currently-defined ARIA attributes which are not available in ARIAMixin:

  • aria-channel
  • aria-datatype
  • aria-dropeffect
  • aria-grab
  • aria-relevant
  • aria-secret
  • aria-templateid

I assume these are deprecated/nonstandard, but I don't see a strong reason to remove them since I'm not sure if any downstream code is relying on them. (Update: it turns out the WPT tests still reference aria-relevant.)

BTW I did not find any tests for the existing aria-* attributes, but I'd be happy to add them as necessary.

@mrobinson mrobinson added this pull request to the merge queue Apr 16, 2024
Merged via the queue into servo:main with commit 1ae2de3 Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants