Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 2018 syntax and misc updates #280

Closed
wants to merge 7 commits into from
Closed

Conversation

lrazovic
Copy link
Contributor

In this PR i wanted to take advantage of the idioms of Rust 2018, update the dependecies to the latest public version and remove deprecated code.

  • crossbeam-channel updated from 0.4 to 0.5.
  • rand from 0.7 to 0.8.
  • crossbeam-utils from 0.7 to 0.8.
  • Removed the extern crate and #[macro_use] syntax, replaced by use where it's needed.
  • Replaced std::mem::replace with std::mem::take.
  • [In unsafe fn] Replaced the decprecated mem::uninitialized with mem::MaybeUninit::uninit().
  • [In unsafe code block] Replaced ptr.offset(offset as isize) with ptr.add(offset). relative clippy lint

Tested with:

  • cargo +nightly build --release --all-features --all-targets
  • cargo +nightly test --all-features --all-targets
  • cargo +nightly bench --all-features --all-targets

I didn't formatted the code with cargo fmt because it would have brought too much changes, if necessary I'm ready to send a new patch.

@highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon.

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #284) made this pull request unmergeable. Please resolve the merge conflicts.

@atouchet
Copy link
Contributor

crossbeam-channel and crossbeam-utils were updated in #299.

@stefnotch
Copy link

I think this can be closed, unless there are some other improvements in this PR?

@lrazovic lrazovic closed this Nov 15, 2023
@mrobinson
Copy link
Member

It looks like the removal of the use of extern crate is still relevant. I can update this PR and land that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants