Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose handler for message bus errors #228

Open
jdm opened this issue Mar 29, 2019 · 3 comments
Open

Expose handler for message bus errors #228

jdm opened this issue Mar 29, 2019 · 3 comments
Labels

Comments

@jdm
Copy link
Member

jdm commented Mar 29, 2019

Per this IRC conversation, it would be easier to diagnose system configuration issues if the webrtc code did not silently swallow message bus error messages.

@jdm jdm added the webrtc label Mar 29, 2019
@jdm
Copy link
Member Author

jdm commented Mar 29, 2019

The audio decoder does this; not clear if any other code handles bus error messages.

@philn
Copy link
Contributor

philn commented Mar 29, 2019

for the MediaPlayer, as it's based on GstPlayer (AFAIK), you could rely on the error signal, https://slomo.pages.freedesktop.org/rustdocs/gstreamer/gstreamer_player/struct.Player.html#method.connect_error

@philn
Copy link
Contributor

philn commented Mar 29, 2019

Ah that's done in the player, already, https://github.com/servo/media/blob/master/backends/gstreamer/src/player.rs#L565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants