Rename servo_media_derive to servo-media-derive
#414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagudev
reviewed
Jan 1, 2024
servo-media-derive/Cargo.toml
Outdated
| version = "0.1.0" | ||
| authors = ["Fernando Jiménez Moreno <ferjmoreno@gmail.com>"] | ||
|
|
||
| [lib] | ||
| name = "servo_media_derive" |
There was a problem hiding this comment.
Oops. You're right. This is reverted now
This is the only servo media package that uses underscores in the name when all the others use dashes.
mrobinson
force-pushed
the
media-derive
branch
from
15a28e7
to
b86700f
Compare
|
Can you actually do such a rename and have the publish work? |
As far as I know these crates are not published on crates.io, but am I misunderstanding your question? |
Manishearth
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only servo media package that uses underscores in the name
when all the others use dashes.