Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the workaround for gcc bug.43949? #305

Closed
Chandlerooo opened this issue Aug 8, 2022 · 1 comment
Closed

Remove the workaround for gcc bug.43949? #305

Chandlerooo opened this issue Aug 8, 2022 · 1 comment

Comments

@Chandlerooo
Copy link

I notice there is a trivial workaround for gcc bug 43949:
https://github.com/servo/mozjs/blob/master/mozjs/js/src/jit/arm/Simulator-arm.cpp

int32_t Simulator::get_register(int reg) const {
  MOZ_ASSERT(reg >= 0 && reg < num_registers);
  // Work around GCC bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43949
  if (reg >= num_registers) return 0;
  return registers_[reg] + ((reg == pc) ? SimInstruction::kPCReadOffset : 0);
}

This compiler bug is already marked as fixed :
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43949
Shall this workaround be removed?

@jdm
Copy link
Member

jdm commented Aug 8, 2022

This code is imported from upstream releases that originate from Firefox. We only apply patches that fix problems that affect Servo directly.

@jdm jdm closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants