ir: Don't panic when finding an unknown calling convention until code generation #722
Conversation
|
If I were you, I would probably still distinguish between invalid and unsupported in the warning, and use "unsupported" rather than "unknown" in the panic message. But I guess this is fine as well. (It seems LLVM server is done, or at least Travis CI fails to connect to it...) |
|
r=me with CI passing |
|
@bors-servo r=fitzgen Let's see if llvm.org happens to be up |
|
📌 Commit f2c2b78 has been approved by |
ir: Don't panic when finding an unknown calling convention until code generation This unblocks stylo in windows until we get `__thiscall` support in syntex. see #541.
|
☀️ Test successful - status-travis |
|
@emilio or @fitzgen, when you get a chance, can you please publish a new rust-bindgen release with this |
|
It's published :).
Let me know if you need me to do a bindgen upgrade in Servo too.
…On Fri, May 26, 2017 at 03:57:47PM -0700, Chris Peterson wrote:
@emilio or @fitzgen, when you get a chance, can you please publish a new rust-bindgen release with this `__thiscall` fix? We need this to build Stylo on Win32. ([Firefox bug 1366048](https://bugzil.la/1366048))
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#722 (comment)
|
Yes, please! I filed servo/servo#17070 issue requesting the rust-bindgen version bump to v0.25.3 |
This unblocks stylo in windows until we get
__thiscallsupport in syntex. see #541.