Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark tests for color parsing #319

Open
GPHemsley opened this issue Jan 22, 2023 · 5 comments
Open

Add benchmark tests for color parsing #319

GPHemsley opened this issue Jan 22, 2023 · 5 comments

Comments

@GPHemsley
Copy link
Contributor

Spinning off from #314:

With the complexities involved with parsing colors, there are concerned about regressing the time it takes to parse them.

Per @emilio:

But it should be rather trivial to add a few benchmarks for color parsing in src/tests.rs like we have for data: uris etc?

We should look into that.

@sculpt0r
Copy link

Hi :)
Do you think this issue could be a good candidate to start contribute? If so, may I take this one?

@emilio
Copy link
Member

emilio commented Jan 1, 2024

Hey, sure thing, go ahead!

@sculpt0r
Copy link

sculpt0r commented Apr 3, 2024

It has been a long time...
If I'm not mistaken, there is no benchmarking at all in GH workflow, despite bench feature marks in the test code.

I'm fully rely on the docs: https://doc.rust-lang.org/unstable-book/library-features/test.html

So, part of this issue solve will be adding some custom workflow?

@emilio
Copy link
Member

emilio commented Apr 6, 2024

I don't think we necessarily need a custom workflow, just something that can be benchmarked easily locally.

@emilio
Copy link
Member

emilio commented Apr 6, 2024

Of course the more we can automate after that the better, but that's not a strict requirement imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants